Conversation
lfoppiano
force-pushed
the
bugfix/crt-credentials
branch
from
August 17, 2026 18:07
232629e to
e2f8b92
Compare
- add missing dependency need when an aws login session is available - add --profile to use specific AWS profiles
lfoppiano
force-pushed
the
bugfix/crt-credentials
branch
from
August 17, 2026 18:10
e2f8b92 to
2c9b568
Compare
lfoppiano
marked this pull request as draft
August 17, 2026 18:36
lfoppiano
marked this pull request as ready for review
August 17, 2026 18:50
# Conflicts: # README.md # pyproject.toml # uv.lock # warc2zip.py
Collaborator
Author
|
I've merged main into there, so @parismic you can test anything you want :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws login(@parismic method) is acktually very standard. Not only is standard, it's better than using access key credentials.warcio[s3]may support it in the future, but addingbotocore[crt]may have additional unexpected impacts (e.g. it overrides other mechanism used by default in botocore3) -- I did not investigate those, just mentioning thembotocore[crt]is required foraws loginauth mechanismThis fixes #1