Skip to content

Fix CRT Credential missing dependency - #5

Open
lfoppiano wants to merge 9 commits into
mainfrom
bugfix/crt-credentials
Open

lfoppiano wants to merge 9 commits into
mainfrom
bugfix/crt-credentials

Conversation

@lfoppiano

@lfoppiano lfoppiano commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator
  1. aws login (@parismic method) is acktually very standard. Not only is standard, it's better than using access key credentials.
  2. since warc2zip needs to work on s3 regardless their auth system, we add the dependency.
  3. Eventuall warcio[s3] may support it in the future, but adding botocore[crt] may have additional unexpected impacts (e.g. it overrides other mechanism used by default in botocore3) -- I did not investigate those, just mentioning them
  4. The README.MD explains more clearly that botocore[crt] is required for aws login auth mechanism

This fixes #1

@lfoppiano
lfoppiano force-pushed the bugfix/crt-credentials branch from 232629e to e2f8b92 Compare August 17, 2026 18:07
  - add missing dependency need when an aws login session is available
  - add --profile to use specific AWS profiles
@lfoppiano
lfoppiano force-pushed the bugfix/crt-credentials branch from e2f8b92 to 2c9b568 Compare August 17, 2026 18:10
@lfoppiano
lfoppiano marked this pull request as draft August 17, 2026 18:36
@lfoppiano
lfoppiano marked this pull request as ready for review August 17, 2026 18:50
@lfoppiano
lfoppiano requested a review from parismic August 17, 2026 18:50
@lfoppiano

Copy link
Copy Markdown
Collaborator Author

I've merged main into there, so @parismic you can test anything you want :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing dependency: s3:// needs botocore[crt]

1 participant