Skip to content

Correct extensions for DNS and robots.txt - #11

Merged
wumpus merged 5 commits into
mainfrom
fix/dns-type
Aug 24, 2026
Merged

wumpus merged 5 commits into
mainfrom
fix/dns-type

Conversation

@lfoppiano

@lfoppiano lfoppiano commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Updated

As mentioned in #10:

  • dns -> .dns
  • robots.txt -> .robots

@lfoppiano
lfoppiano requested a review from wumpus August 24, 2026 18:55
Signed-off-by: Luca Foppiano <luca@foppiano.org>
@lfoppiano lfoppiano changed the title Use .bin instead .txt for DNS records Correct extensions for DNS and robots.txt Aug 24, 2026
@lfoppiano
lfoppiano marked this pull request as draft August 24, 2026 19:00
@lfoppiano
lfoppiano removed the request for review from wumpus August 24, 2026 19:00
@wumpus

wumpus commented Aug 24, 2026

Copy link
Copy Markdown
Member

I wanted .dns and .robots for both warc and arc, this PR has a bunch of whitespace changes and leaves dns records as .bin

oops

@lfoppiano

Copy link
Copy Markdown
Collaborator Author

Yes, sorry! 🙏
I had reacted too fast ... I'm setting it back in review once I'm done.

@lfoppiano
lfoppiano marked this pull request as ready for review August 24, 2026 19:37
@lfoppiano

Copy link
Copy Markdown
Collaborator Author

Reverted the useless space noise, added the robots.txt (URL-based extension). Looks good when converting WARC of robots.txt:

warc2zip  s3://commoncrawl/crawl-data/CC-MAIN-2026-25/segments/1780687572126.23/robotstxt/CC-MAIN-20260606065401-20260606095401-00996.warc.gz

@lfoppiano
lfoppiano requested a review from wumpus August 24, 2026 19:40
@wumpus
wumpus merged commit 64b80b1 into main Aug 24, 2026
4 checks passed
@wumpus
wumpus deleted the fix/dns-type branch August 24, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants