Skip to content

WIP - #3295

Open
valoriecarli wants to merge 11 commits into
mainfrom
FEC-1127-and-friends
Open

WIP#3295
valoriecarli wants to merge 11 commits into
mainfrom
FEC-1127-and-friends

Conversation

@valoriecarli

@valoriecarli valoriecarli commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Converts 25 Percy visual routes into Storybook stories that Chromatic captures.
The goal is parity: the same states, same props and same order the Percy
routes already have, so Chromatic can take over without changing what is covered.

Description

Ticket Scope
FEC-1227 icons, spacings, dropdown-menu — the unconventional routes
FEC-1228 Select inputs
FEC-1229 Text inputs
FEC-1230 Localized inputs
FEC-1231 Date and time inputs
FEC-1232 Numeric and choice inputs

Each component gains an AllVariants story appended to its existing stories
file, tagged vrt and opted into capture with
chromatic: { disableSnapshot: false }. Demo stories are untouched and stay
uncaptured.

Parity, not new coverage. States whose percySnapshot is commented out are
skipped — no baseline exists for them today, so converting them would add
coverage rather than migrate it.

Nothing Percy is deleted. Route files, specs and the Percy CI step all stay
until parity is signed off.

Shared changes, worth a closer look

  • storybook/src/helpers/visual-spec.tsx — the content column now has a definite
    width, so components using horizontalConstraint render at their true size
    instead of collapsing. Also adds row dividers and top-aligned labels. This
    affects every VRT story, not only the new ones.
  • Four spacings packages now declare text / constraints as
    devDependencies; their stories relied on hoisting and failed on a clean
    install.
  • CONTRIBUTING.md notes the migration, and that Percy specs are still required
    until teardown.

Deliberate deviations from Percy

  • icons colour stories are hidden from the sidebar with !dev; Chromatic still
    captures them.
  • dropdown-menu has no play function: Percy's spec clicks the trigger open, but
    its captured baseline shows the menu closed.
  • A few invalid props the route files passed were dropped or corrected, in each
    case where the component ignored the value so the render is unchanged.

Follow-up

A final cleanup round happens once all snapshots are gathered. Presentation
details are deliberately not being polished component by component: label
formatting and alignment, whether the demo stories fold into the captured set,
and the Percy teardown all land in one pass at the end, when the full set of
baselines exists to judge them against.

@changeset-bot

changeset-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7495ec7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ui-kit Ready Ready Preview Aug 11, 2026 2:41pm

Request Review

@valoriecarli
valoriecarli marked this pull request as ready for review August 11, 2026 14:40
@valoriecarli
valoriecarli requested a review from a team as a code owner August 11, 2026 14:40
@valoriecarli valoriecarli changed the title Fec 1127 and friends WIP Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant