WIP - #3295
Open
valoriecarli wants to merge 11 commits into
Open
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
valoriecarli
force-pushed
the
FEC-1127-and-friends
branch
from
August 10, 2026 20:12
3c56779 to
6d2a63a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts 25 Percy visual routes into Storybook stories that Chromatic captures.
The goal is parity: the same states, same props and same order the Percy
routes already have, so Chromatic can take over without changing what is covered.
Description
icons,spacings,dropdown-menu— the unconventional routesEach component gains an
AllVariantsstory appended to its existing storiesfile, tagged
vrtand opted into capture withchromatic: { disableSnapshot: false }. Demo stories are untouched and stayuncaptured.
Parity, not new coverage. States whose
percySnapshotis commented out areskipped — no baseline exists for them today, so converting them would add
coverage rather than migrate it.
Nothing Percy is deleted. Route files, specs and the Percy CI step all stay
until parity is signed off.
Shared changes, worth a closer look
storybook/src/helpers/visual-spec.tsx— the content column now has a definitewidth, so components using
horizontalConstraintrender at their true sizeinstead of collapsing. Also adds row dividers and top-aligned labels. This
affects every VRT story, not only the new ones.
spacingspackages now declaretext/constraintsasdevDependencies; their stories relied on hoisting and failed on a clean
install.
CONTRIBUTING.mdnotes the migration, and that Percy specs are still requireduntil teardown.
Deliberate deviations from Percy
iconscolour stories are hidden from the sidebar with!dev; Chromatic stillcaptures them.
dropdown-menuhas no play function: Percy's spec clicks the trigger open, butits captured baseline shows the menu closed.
case where the component ignored the value so the render is unchanged.
Follow-up
A final cleanup round happens once all snapshots are gathered. Presentation
details are deliberately not being polished component by component: label
formatting and alignment, whether the demo stories fold into the captured set,
and the Percy teardown all land in one pass at the end, when the full set of
baselines exists to judge them against.