Fix for Downshift upgrade - #3265
Open
jaikumar-tj wants to merge 5 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 18ee8d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 97 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ezone change - Always call useCombobox's getMenuProps during render (spread onto the calendar menu only when shown) so downshift no longer logs "You forgot to call the getMenuProps getter function" on mount, which threw in CI tests. - Re-sync the displayed input value when locale/timeZone change, restoring the behavior the old <Downshift key=...> remount provided. - Fix date-range-input selection state transitions (first/second click and explicit clear/Escape branch). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds an explicit test to each date input spec that spies on console.error and asserts the "You forgot to call the getMenuProps getter function" warning is never logged on mount. Unlike the implicit CI-only console.error-throws behavior, this fails deterministically both in CI and locally, so a regression in the useCombobox migration is caught immediately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tdeekens
approved these changes
Jul 21, 2026
misama-ct
requested changes
Jul 21, 2026
misama-ct
left a comment
misama-ct
left a comment
Contributor
There was a problem hiding this comment.
I found visual and behavioral regressions as well as breaking changes. None of those issues were caught by the current tests or were covered up by the test changes in this PR.
Please do not merge, I'll try to figure out how to move forward.
tdeekens
self-requested a review
July 21, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/commercetools/merchant-center-frontend/pull/20867#discussion_r3480667280