Skip to content

Do not crash the host when a template names a table that is gone #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skfd wants to merge 1 commit into from
Closed

Do not crash the host when a template names a table that is gone #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Helper/entity.partial.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,13 @@ public static string GetFormattedAttribValue(this Entity entity, string attribut
{
try
{
if (null != entity && entity.Attributes.Contains(attributeLogicalName))
// Guard on the collection being indexed, not on Attributes. An attribute can
// be present with no formatted value beside it, and then this indexer throws.
// associatedentitytypecode is the one that bites: Dataverse only sends a
// formatted value for it when it can resolve the table, so a template whose
// table was deleted, or that came from another organization, arrives as
// 'none' with nothing formatted and takes the whole load down with it.
if (null != entity && entity.FormattedValues.Contains(attributeLogicalName))
{
return entity.FormattedValues[attributeLogicalName];
}
Expand Down