fix(search): fetch head sha client only - #50
Conversation
◈ PR Lens
Architecture 3 components touched across 3 lanes. Data flow
View
Tip Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds. 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change separates navigation and SHA loading, defers search warmup until SHA resolution, and removes availability checks from the search composable and related components. ChangesSearch loading flow
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No confirmed merge-blocking risk remains in the changed search loading flow. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
app/app.vueOops! Something went wrong! :( ESLint: 10.10.0 A configuration object specifies rule " Common causes of this problem include:
app/components/AppHeader.vueESLint skipped: the matched ESLint configuration already failed (unknown). app/components/AppSearch.vueESLint skipped: the matched ESLint configuration already failed (unknown).
Comment |
commit: |
The search index SHA was fetched during SSR, so it got baked into each page's ISR cache entry => landing on a page whose cached entry predated a content push pinned search to the old commit for the whole session.
Now fetched client-side only (server: false), so it always reflects the current head.
Also: the search button and palette always render instead of being gated on the SHA resolving.
Summary by CodeRabbit
New Features
Bug Fixes