feat: file navigation, review tracking, and diff improvements#23
Open
hay-kot wants to merge 8 commits into
Open
feat: file navigation, review tracking, and diff improvements#23hay-kot wants to merge 8 commits into
hay-kot wants to merge 8 commits into
Conversation
Previously gf destroyed the review layout to open the file. Now it switches to the original tab, preserving all review state. Use gr or :DiffReviewReturn to switch back to the review.
Toggle files as reviewed with 'x' from either pane. Reviewed files show a green checkmark and dimmed text. Progress counter (N/N) in the stats header. State persists across sessions via the review JSON.
Replace buffer line numbers with actual old/new file line numbers using statuscolumn. Context lines show both, added lines show only new, deleted lines show only old. Width adapts to the max line number.
Distinguish hunk headers (@@) from file metadata (diff --git, index, ---, +++). Only hunk headers get the separator line in the gutter; metadata lines show no gutter at all.
Only show line numbers for actual code lines. Hunk headers and metadata lines get a blank gutter.
- Fix <leader>c by removing c/C from <Nop> block list - Prevent note mode keymaps from overriding diff review keymaps - Show file line numbers instead of buffer lines in comment display - Highlight commented lines in custom statuscolumn gutter - Hide line numbers on virtual text lines (vim.v.virtnum) - Remove gutter border separator character - Add blank separator lines between diff hunks - Account for separator offsets in export and GitHub submit - Remove emoji from export output - Preserve diff add/delete highlights when comment_line_hl is unset
- Blend DiffAdd/DiffDelete backgrounds toward Normal bg for subtler tints - Add diff.highlight_blend config option (0.0 = full color, 1.0 = invisible, default 0.60) - Re-define highlights on ColorScheme change for theme switching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gfopens file in original tab instead of closing review, with split/vsplit support andgrto returnx, persisted across sessions, with visual indicators in file list<leader>cbinding, prevent note mode from overriding diff keymaps, show file line numbers instead of buffer lines in comments and exportsdiff.highlight_blendoption to soften DiffAdd/DiffDelete backgrounds, adapts to colorscheme changesTest plan
DiffReview maingfopens file in original tab,grreturns to reviewx, close and reopen to verify persistence<leader>c, verify file line numbers in display and exporthighlight_blendconfig option at various values