DRYD-1633: Core Dependency Updates#535
Open
mikejritter wants to merge 26 commits into
Open
Conversation
Start Upgrade Process
* Updates our XSDs to use the jakarta namespace * Update version and configuration for the jaxb-maven-plugin * Add dependencies for jaxb modules
* Migrate hyperjaxb module from xsd to classes
* Migrate account from xsd to classes * Replace field access with getter
* Migrate authentication from xsd to classes
* Authorization migrate xsd to classes
* Replace javax.xml.bind imports with jakarta * Replace NameCoverter import
* Add ant module to download js libs * Update build scripts to include ant classpath * Rework scriptdefs to run with prepare-ant-libs as a dependency
* Update hibernate to 5.6.15.Final to match nuxeo * Move annotations on created/updatedAt to fields * Create DateAdapter for XML serialization * Prefer javax.transaction connection properties * Remove unused connection properties
* Update nuxeo.general.release to 2023.39 * Update nuxeo repository * Add enforcer plugin for dependency constraints * Nuxeo Updates * Migrate getLocalService to getService * Replace ClientException with NuxeoException * ES API updates * Fulltext API updates * CoreSession API updates * DocModel API update * Remove ScopeType/ScopedMap * Replace getPath with getXPath * CMIS updates * Dependency changes * jackson -> 2.19.4 * stax2-api -> 4.2.2 * groovy -> 2.4.21 * guava -> 32.1.3-jre * commons-codec -> 1.18.0 * commons-io -> 2.19.0 * commons-lang3 -> 3.18.0 * Add exclusion for woodstox-core-asl * Add missing Transient annotation on AccountsCommon * Remove unused files
* Upgrades RESTEasy to v5.x * Remove resteasy-jaxb-provider * Replace resteasy-jaxrs with resteasy-client for clients * Add JakartaJAXBProvider for XMLRootElement marshalling * Add JAXBContextCache for caching JAXBContexts * Replace ObjectFactory usage with jaxb.index * Prefer XMLRootElement * Add XMLSchema to package-info for namespaces in marshalled responses
* Update fulltext query for authority refs * Add boolean parameter for toggling cleaning of keywords * Misc cleanup (type inference, modifier sorting, etc)
* Add jaxb-runtime when required for testing * Add authorization jaxb when required for testing * URL Encode '%' in XMLReplayTest * Replace hibernate.cfg.xml with persistence.xml * Remove unnecessary hibernate/persistence files * Update tomcat version
* Replace deprecated blob creation methods * Configuration for Nuxeo's RecomputeViews bulk action * Handle view computation ourselves * Cleanup imports, logging, modifiers * Set variable when shutting down
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
I am running integration tests locally and found the following issue: The This is a regression because a |
Contributor
|
The only other failing test is: All rest are green. |
Contributor
Author
|
@spirosdi I'll look into the For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1633
This updates many of CollectionSpace's core dependencies which allow it run with Java 17 and Tomcat 9. The commits involve more changes to each dependency which was changed, e.g. updating persistence.xml, imports, deprecated methods.
How should this be tested? Do these changes have associated tests?
mvn testto check that they passDependencies for merging? Releasing to production?
Before merging we should make sure changes are in place to the nightly build and to the hosted dev site to be prepared for the switch.
Before releasing to production we will need to do regression testing to ensure all functionality is working.
Has the application documentation been updated for these changes?
The following documentation needs to be updated:
It will probably be easiest to make a ticket to track what changes to make.
Did someone actually run this code to verify it works?
@mikejritter has been testing locally
Have any new security vulnerabilities been handled?
Yes, an XXE issue was discovered which would affect parsing XML and DTD has been disabled as a result.