release v0.8.1 — strict PIC instantiate-assert#36
Merged
Conversation
…C child) The PIC loader now REJECTS a non-PIC module at instantiate (checks it imports env.__memory_base) instead of instantiating it and trapping on the first host-fn call. This turns a forgotten-to-rebuild (pre-0.8/non-PIC) actor from a silent- until-first-call failure into a legible failure at boot — the fail-loud property the fleet-lockstep rollout wants, most of all for the mail spine (a mis-flipped mail actor now fails at startup, not on the first inbound email). - runtime: assert_pic_module() gates both PIC instantiate paths (sync pic_link + async theater path). Non-PIC -> clear error naming the fix (rebuild with the 0.8.x PIC recipe). Regression: pic_loader_rejects_nonpic_guest_at_instantiate. - tests: the host-fn / interceptor unit tests instantiate inline non-PIC WAT on the async path as a convenience; add an (unused) env.__memory_base import so they satisfy the assert with no behavior change. Non-breaking for real consumers: PIC guests are unaffected; a non-PIC guest was already broken (trapped on first call) — it now fails earlier and legibly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release v0.8.1 — strict PIC instantiate-assert (fail-loud on a non-PIC child)
HELD for Colin's go on the publish (merging publishes 0.8.1 to crates.io). Colin approved the hardening + the test updates; this is prepped and awaiting the explicit cut.
What
The PIC loader now rejects a non-PIC module at instantiate (checks it imports
env.__memory_base) instead of instantiating it and trapping on the first host-fn call. A forgotten-to-rebuild (pre-0.8/non-PIC) actor goes from silent-until-first-call to a legible failure at boot — the fail-loud property the rollout wants, most of all for the mail spine (a mis-flipped mail actor fails at startup, not on the first inbound email).runtime:assert_pic_module()gates both PIC instantiate paths (syncpic_link+ the async theater path); non-PIC → a clear error naming the fix. Regression testpic_loader_rejects_nonpic_guest_at_instantiate.tests: the host-fn/interceptor unit tests instantiate inline non-PIC WAT on the async path as a convenience — added an (unused)env.__memory_baseimport so they satisfy the assert with no behavior change.Impact
Full workspace green (26 suites), clippy + fmt clean.
🤖 Generated with Claude Code