fix: package the embedded allocator wasm as a committed asset (unblocks 0.8.0 publish)#34
Merged
Merged
Conversation
The PIC runtime embeds packages/pack-alloc via include_bytes!, but that path was under target/ (gitignored) — so it is absent from the published crate and cargo publish fails its verification build (couldn't read pack_alloc_module.wasm). Move it to a committed asset at assets/pack_alloc_module.wasm (an embedded runtime component, not a build artifact) and include_bytes! from there; the tests read the same asset. CI/publish no longer build pack-alloc (only the echo-pic/hostcall-pic test fixtures), and the publish workflow gains that fixture build before its test step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
colinrozzi
force-pushed
the
fix-pack-alloc-asset
branch
from
edfba5e to
bebcbbe
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package the embedded allocator wasm as a committed asset
Follow-up to #33 (PIC composition), required before
0.8.0can publish.The PIC runtime embeds
packages/pack-allocviainclude_bytes!, but the path was undertarget/(gitignored) — so it's absent from the published crate, andcargo publishfails its verification build:(Verified locally with
cargo package -p packr— fails before, passes after.)Fix
assets/pack_alloc_module.wasm(an embedded runtime component, not a build artifact) andinclude_bytes!from there. Documented how to regenerate it.echo-pic/hostcall-picfixtures.After this,
cargo publish -p packrverify-builds clean and the.wasmis in the package tarball.🤖 Generated with Claude Code