Skip to content

v5.8.1 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jclausen merged 4 commits into from
Oct 27, 2025
Merged

v5.8.1 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67bc88e
bump patch [ci skip]
jclausen Feb 25, 2025
bfbf1a1
Merge branch 'master' into development
jclausen Feb 25, 2025
48e6be8
Add better debugging error output for XML responses
jclausen Oct 7, 2025
c43bc3f
Update for AWS Deprecation of Display name
jclausen Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion box.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name":"Amazon S3 SDK",
"version":"5.8.0",
"version":"5.8.1",
"slug":"s3sdk",
"location":"https://downloads.ortussolutions.com/ortussolutions/coldbox-modules/s3sdk/@build.version@/s3sdk-@build.version@.zip",
"author":"Ortus Solutions, Corp",
Expand Down
5 changes: 3 additions & 2 deletions models/AmazonS3.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ component accessors="true" singleton {
"type" : node.grantee.XMLAttributes[ "xsi:type" ],
"displayName" : "",
"permission" : node.permission.XMLText,
"uri" : node.grantee.XMLAttributes[ "xsi:type" ] == "Group" ? node.grantee.uri.xmlText : node.grantee.displayName.xmlText
// TODO:
"uri" : node.grantee.XMLAttributes[ "xsi:type" ] == "Group" ? node.grantee.uri.xmlText : ( node.grantee.displayName.xmlText ?: node.grantee.ID.xmlText )
};
} );
}
Expand Down Expand Up @@ -1776,7 +1777,7 @@ component accessors="true" singleton {
throw(
type = "S3SDKError",
message = "Error making Amazon REST Call: #results.message#",
detail = serializeJSON( results.response )
detail = isXML( results.response ) ? toString( results.response ) : serializeJSON( results.response )
);
}

Expand Down
Loading