fix(installer): preserve symlinks when writing agent config files#433
Open
0x1306a94 wants to merge 1 commit into
Open
fix(installer): preserve symlinks when writing agent config files#4330x1306a94 wants to merge 1 commit into
0x1306a94 wants to merge 1 commit into
Conversation
0x1306a94
force-pushed
the
fix/symlink-preservation-in-installer
branch
from
4db248f to
ffd8b35
Compare
atomicWriteFileSync used write-tmp-then-rename, which replaces the directory entry and breaks symlinks. Resolve symlinks to their real target path before writing so shared AGENTS.md / CLAUDE.md setups survive reinstall.
0x1306a94
force-pushed
the
fix/symlink-preservation-in-installer
branch
from
ffd8b35 to
f5deed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomicWriteFileSyncuses a write-tmp-then-rename pattern, which replaces the directory entry (inode) and breaks symlinksresolveSymlink()helper that checkslstatSync+isSymbolicLink()and resolves viarealpathSync(with manualreadlinkSyncfallback for dangling symlinks)atomicWriteFileSyncandremoveMarkedSectionnow resolve symlinks before writing/unlinking, so sharedAGENTS.mdCLAUDE.mdvia symlink survives reinstallMotivation
Users may share a single AGENTS.md across multiple agents via symlinks:
Previously, running
codegraph install --target claude,codex --yeswould replace these symlinks with regular files, breaking the shared setup. This fix ensures symlinks are followed and the real target file is written to.Test plan