Conversation
5008ce4 to
4133851
Compare
There was a problem hiding this comment.
Pull request overview
Adds interactive “mutating” queue/task actions to the Textual-based inspector (confirm/retype modals + keyboard bindings), backed by new backend APIs and Redis implementations, with accompanying tests and README updates.
Changes:
- Add confirmation modal screens (
ConfirmScreen,PurgeScreen) and dialog styling for inspector actions. - Add inspector keybindings/actions to requeue failed tasks, dequeue tasks, and purge queues (with confirmation flows).
- Extend backend API with
dequeue()/purge()and implement them (plus extra Redis cleanup inrequeue()), with expanded test coverage and docs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| threadmill/inspector/screens.py | Adds modal confirmation screens for destructive/confirmable inspector actions. |
| threadmill/inspector/inspector.scss | Adds dialog styling and global screen alignment (needs scoping adjustment). |
| threadmill/inspector/app.py | Adds keybindings and action handlers for refresh/requeue/dequeue/purge in the inspector. |
| threadmill/backends/redis.py | Adds Redis implementations for dequeue/purge and improves requeue cleanup. |
| threadmill/backends/base.py | Extends backend interface with dequeue/purge APIs and expands requeue docstring. |
| tests/test_inspector.py | Adds extensive inspector action and modal interaction tests. |
| tests/backends/test_redis.py | Adds Redis backend tests for requeue cleanup, dequeue, and purge behavior. |
| tests/backends/test_base.py | Adds base backend NotImplementedError tests for new APIs. |
| README.md | Documents inspector queue actions and shortcuts (currently mismatched for dequeue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.