Feat/events multiselect bulk actions by Dobrunia · Pull Request #640 · codex-team/hawk.api.nodejs

Dobrunia · 2026-04-22T10:36:23Z

Summary

Introduces multi-select on the project daily events list with a bulk action bar

neSpecc · 2026-04-22T12:56:59Z

unexpected change

neSpecc · 2026-04-22T12:58:28Z

+  /**
+   * Max original event ids per bulkToggleEventMark request
+   */
+  static get BULK_TOGGLE_EVENT_MARK_MAX() {
+    return 100;
+  }


specify exact problem

neSpecc · 2026-04-22T12:59:15Z

+    if (mark !== 'resolved' && mark !== 'ignored' && mark !== 'starred') {
+      throw new Error(`bulkToggleEventMark: mark must be resolved, ignored or starred, got ${mark}`);
+    }


validation should be on resolver level (or via graphql schema)

…signees

…or handling in bulkToggleEventMark and bulkUpdateAssignee methods

…ventMarks and clean up related tests

…e events as visited for a user

…hod for improved code reuse and clarity

Copilot

Pull request overview

Adds backend support and test coverage for multi-select bulk actions on events, including bulk visit, bulk mark toggle, and bulk assignee updates.

Changes:

Introduces new GraphQL mutations/types for bulk visiting events, bulk toggling marks, and bulk updating assignees.
Adds resolver/helper logic to validate/dedupe bulk IDs, merge invalid IDs into failedEventIds, and enqueue assignee notifications asynchronously.
Implements EventsFactory bulk operations and adds Jest tests for resolvers/helpers/factory methods.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/resolvers/event-bulk-visit.test.ts	Adds resolver tests for `bulkVisitEvents` validation + failed ID merging
test/resolvers/event-bulk-update-assignee.test.ts	Adds resolver tests for `EventsMutations.bulkUpdateAssignee` and notification enqueueing
test/resolvers/event-bulk-toggle-marks.test.ts	Adds resolver tests for `bulkToggleEventMarks` semantics + validation
test/resolvers/bulk-events-helper.test.ts	Adds helper tests for fire-and-forget notification enqueueing
test/models/eventsFactory-bulk-visit.test.ts	Adds model tests for `EventsFactory.bulkVisitEvent`
test/models/eventsFactory-bulk-update-assignee.test.ts	Adds model tests for `EventsFactory.bulkUpdateAssignee`
test/models/eventsFactory-bulk-toggle.test.ts	Adds model tests for `EventsFactory.bulkToggleEventMark`
src/typeDefs/event.ts	Adds new GraphQL inputs/types/mutations for bulk operations
src/resolvers/helpers/bulkEvents.js	Adds bulk ID parsing/merging helpers + async notification enqueue helper
src/resolvers/event.js	Wires new bulk mutations and switches assignee notification sending to fire-and-forget
src/models/eventsFactory.js	Implements bulk visit, bulk mark toggle, bulk assignee update, and shared resolver for bulk IDs
package.json	Bumps package version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-23T13:50:26Z


+  """
+  Toggle the same mark on many original events at once (resolved, ignored or starred).
+  Same toggle semantics as toggleEventMark per event.


The mutation comment says “Same toggle semantics as toggleEventMark per event”, but this bulk operation has different semantics (it only clears when all selected already have the mark). Please adjust the docstring so clients don’t assume per-event toggling behavior.

Suggested change

Same toggle semantics as toggleEventMark per event.

Uses bulk semantics: if every selected event already has the mark, clear it for all;

otherwise set it on each selected event that does not have it yet.

Copilot · 2026-04-23T13:50:27Z

+type BulkToggleEventMarksResult {
+  """
+  Number of events updated in the database
+  """
+  updatedCount: Int!
+
+  """
+  Original event ids actually toggled in this operation
+  """
+  updatedEventIds: [ID!]!
+
+  """
+  Event ids that were not updated (invalid id or not found)
+  """
+  failedEventIds: [ID!]!
+}
+
+"""
+Result of bulk marking events as viewed
+"""
+type BulkVisitEventsResult {
+  """


Type naming is inconsistent: the file predominantly uses *Response (e.g., UpdateAssigneeResponse, BulkUpdateAssigneeResponse), but these new types use *Result. Consider renaming them to BulkToggleEventMarksResponse / BulkVisitEventsResponse (or switching all bulk types to *Result) to keep the public GraphQL schema consistent.

Copilot · 2026-04-23T13:50:27Z

+  Promise.allSettled(eventIds.map(eventId => sendPersonalNotification(assigneeData, {
+    type: 'assignee',
+    payload: {
+      assigneeId,
+      projectId,
+      whoAssignedId,
+      eventId,
+    },
+  })))


Promise.allSettled(eventIds.map(...)) will fire all notification enqueues at once. With large bulk selections this can create an unbounded burst of RabbitMQ enqueue calls and memory pressure. Consider batching/chunking or applying a concurrency limit (e.g., a small pool) while still keeping the resolver non-blocking.

Copilot · 2026-04-23T13:50:27Z

+    .then((results) => {
+      const failedResults = results.filter(result => result.status === 'rejected');
+
+      if (failedResults.length > 0) {
+        console.error('Failed to enqueue assignee notifications', failedResults);
+      }
+    })
+    .catch((error) => {
+      console.error('Failed to enqueue assignee notifications', error);
+    });


failedResults may contain raw rejection reasons from enqueue (potentially including endpoints or other sensitive details). Logging the full array could leak data into logs; consider logging only counts + sanitized error messages, or at least logging reason.message without payload details.

Copilot · 2026-04-23T13:50:28Z

+      if (assignee) {
+        const userExists = await factories.usersFactory.findById(assignee);
+
+        if (!userExists) {
+          throw new UserInputError('assignee not found');
+        }


assignee is only checked for truthiness. If the client passes an invalid ID (or an empty string), usersFactory.findById() will throw from new ObjectId(id) inside the dataloader instead of returning a controlled UserInputError. Validate assignee explicitly (e.g., ObjectId.isValid) and treat empty string as invalid since the API contract says “pass null to clear”.

neSpecc · 2026-04-23T13:44:46Z

+   * @param {string|ObjectId} userId - id of the user who is visiting events
+   * @returns {Promise<{ updatedCount: number, updatedEventIds: string[], failedEventIds: string[] }>}
+   */
+  async bulkVisitEvent(eventIds, userId) {


Suggested change

async bulkVisitEvent(eventIds, userId) {

async bulkVisitEvents(eventIds, userId) {

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tency across the codebase

codecov-commenter · 2026-04-24T08:42:44Z

Codecov Report

❌ Patch coverage is 91.04478% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.27%. Comparing base (0f8dad9) to head (81a682f).
⚠️ Report is 42 commits behind head on master.

Files with missing lines	Patch %	Lines
src/resolvers/helpers/bulkEvents.js	79.48%	5 Missing and 3 partials ⚠️
src/resolvers/event.js	92.85%	3 Missing ⚠️
src/models/eventsFactory.js	98.11%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #640       +/-   ##
===========================================
- Coverage   58.30%   44.27%   -14.04%     
===========================================
  Files          19       52       +33     
  Lines         518     2487     +1969     
  Branches       95      527      +432     
===========================================
+ Hits          302     1101      +799     
- Misses        216     1311     +1095     
- Partials        0       75       +75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ount from responses and enhancing error handling

…improve clarity

…us and modified count, enhancing response clarity

…anges occur during bulk assignee update

Dobrunia and others added 6 commits April 22, 2026 13:11

Multi-select and bulk actions on the events list

ec4350a

chore: add tests

42287da

fix: lint

40ca14d

feat(events): extend bulk toggle functionality to support starred marks

0593ed3

feat(events): update bulkToggleEventMark to return updatedEventIds

dd309a5

Bump version up to 1.5.1

9a0fc08

neSpecc reviewed Apr 22, 2026

View reviewed changes

Dobrunia and others added 11 commits April 22, 2026 19:44

remove

7ed3481

feat(events): add bulkUpdateAssignee functionality to manage event as…

d497afd

…signees

refactor(events): streamline bulk event ID validation and enhance err…

dd84f03

…or handling in bulkToggleEventMark and bulkUpdateAssignee methods

refactor(events): remove unsupported mark validation from bulkToggleE…

ace53d0

…ventMarks and clean up related tests

feat(events): implement bulkVisitEvents functionality to mark multipl…

530adaa

…e events as visited for a user

refactor(events): consolidate bulk event ID resolution into a new met…

c212292

…hod for improved code reuse and clarity

fix: lint

049bace

fix: lint

f250de5

Bump version up to 1.5.2

ccd4a7e

fix: notif

6535527

Bump version up to 1.5.3

93fd728

neSpecc requested a review from Copilot April 23, 2026 13:44

Copilot started reviewing on behalf of neSpecc April 23, 2026 13:44 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

neSpecc approved these changes Apr 23, 2026

View reviewed changes

Dobrunia and others added 3 commits April 24, 2026 11:38

chore: optimize assignee notification handling with chunked processing

94d4e84

Update src/typeDefs/event.ts

f2ab338

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor(events): rename bulkVisitEvent to bulkVisitEvents for consis…

81a682f

…tency across the codebase

Dobrunia requested review from FeironoX5 and slaveeks April 24, 2026 09:09

FeironoX5 approved these changes Apr 27, 2026

View reviewed changes

refactor(events): simplify bulk event operations by removing updatedC…

c271563

…ount from responses and enhancing error handling

Dobrunia and others added 7 commits April 28, 2026 17:33

refactor(events): rename response types for bulk event operations to …

57582bd

…improve clarity

fix: lint

1e13972

fix

2e9fba0

Bump version up to 1.5.1

0ee4684

fix

c4963c4

refactor(events): update bulk event operations to return success stat…

bf64ade

…us and modified count, enhancing response clarity

test(events): add test to ensure no notifications are sent when no ch…

ae8d3dc

…anges occur during bulk assignee update

neSpecc approved these changes Apr 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/events multiselect bulk actions#640

Feat/events multiselect bulk actions#640
Dobrunia wants to merge 28 commits intomasterfrom
feat/events-multiselect-bulk-actions

Dobrunia commented Apr 22, 2026

Uh oh!

neSpecc Apr 22, 2026

Uh oh!

neSpecc Apr 22, 2026

Uh oh!

neSpecc Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Uh oh!

neSpecc Apr 23, 2026

Uh oh!

codecov-commenter commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	Same toggle semantics as toggleEventMark per event.
	Uses bulk semantics: if every selected event already has the mark, clear it for all;
	otherwise set it on each selected event that does not have it yet.

	async bulkVisitEvent(eventIds, userId) {
	async bulkVisitEvents(eventIds, userId) {

Conversation

Dobrunia commented Apr 22, 2026

Summary

Uh oh!

neSpecc Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

neSpecc Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

neSpecc Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

neSpecc Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Apr 24, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants