Repository navigation
docs(changelog): record NodeHost.console_error (#113) - #116
Merged
Merged
Conversation
#113 added a public framework method and a new addon export with no CHANGELOG entry. That is a deviation from this repo's convention, not a house style: `9238631` (the 0.15.1 closure fix) shows feature commits writing their own `## Unreleased` section with `### Added` / `### Fixed`, which the release commit then renames to the version heading. So `## Unreleased` is not something to invent at release time — it is the mechanism, and it was simply absent from CHANGELOG.md between 0.15.1's release and this cycle because `6f7c915` had just consumed it. Writing it now rather than at release time, because the alternative is reconstructing the rationale from `git log` while cutting a release — the same failure mode as the prose counts CLAUDE.md already warns about, where nothing updates a number once it is embedded. Deliberately not adding a gate for this. The exports-doc gate can prove an export is DOCUMENTED, but "does this change deserve a changelog entry" is a judgment call, and a gate that demands one for every commit would be noise that gets routinely bypassed. Still unrecorded and left as a judgment call: `d7c18cb` from #114 ("fix(runtimes): stop asserting the outcome of a documented race"), which changes a non-required CI gate rather than anything a consumer can observe. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#113 added a public framework method (
NodeHost.console_error) and a new addon export (hostConsoleError) with no CHANGELOG entry. #114'sd7c18cblikewise added none.Why this is a deviation, not house style
I initially assumed this repo wrote its changelog at release time, because
CHANGELOG.mdhad no## Unreleasedsection when I looked. That was wrong, and the history says so plainly:9238631— the 0.15.1 closure fix, a feature commit — created## Unreleasedwith### Added/### Fixeditself.6f7c915— the release commit — renamed## Unreleasedto## 0.15.1 — 2026-09-13.So
## Unreleasedis the mechanism, not something to invent at release time. It was simply absent because6f7c915had just consumed it one commit earlier.Why now rather than at release time
The alternative is reconstructing a feature's rationale from
git logwhile cutting a release. That is the same failure mode CLAUDE.md already warns about for prose counts — "nothing updates numbers embedded in prose" — and it is how a release ships with notes that omit a public API addition.Deliberately not adding a gate
check-exports-doc.mjscan prove an export is documented inEXPORTS.md, which is mechanical. "Does this change deserve a changelog entry" is a judgment call: a gate demanding one per commit would fire on every codegen regeneration and doc tweak, and a noisy gate gets routinely bypassed — which is worse than none, because it then reads as green. This repo's gates are all mechanical for a reason.Left as a judgment call
d7c18cbfrom #114 — "fix(runtimes): stop asserting the outcome of a documented race" — changes a non-required CI gate and nothing a consumer can observe. The CHANGELOG does carry CI items sometimes (0.9.0 has the Node 24 matrix job), so this is arguable either way; I did not add it, since it is your call whether gate-script fixes belong in consumer-facing notes.Docs-only. 816 tests, exports-doc and sync-versions gates green.
🤖 Generated with Claude Code