Skip to content

🤖 fix: stabilize chat input status indicators#3236

Open
ibetitsmike wants to merge 1 commit into
mainfrom
mike/chat-indicators-emr1
Open

🤖 fix: stabilize chat input status indicators#3236
ibetitsmike wants to merge 1 commit into
mainfrom
mike/chat-indicators-emr1

Conversation

@ibetitsmike
Copy link
Copy Markdown
Contributor

@ibetitsmike ibetitsmike commented May 5, 2026

Mux working on behalf of Mike.

Summary

Float automatic TODO and background bash status rows above the workspace chat input when they are the only composer-adjacent chrome, so they can appear without shrinking the transcript viewport or leaving an unused reserved margin.

Background

The transcript scroll region shares a vertical flex layout with input decorations. Rendering automatic status rows in normal flow caused the transcript viewport to shrink, and the bottom-lock behavior then pulled visible chat content upward. Reserving space reduced the shift but left a visible blank rail.

Implementation

  • Split chat input decorations into top flow, automatic, and lower flow groups.
  • Keep the automatic group mounted in one stable subtree, switching only its layout between floating and normal flow so expanded background-process state is preserved.
  • Float automatic rows only when no normal-flow banners are present, preventing overlap with queued/review/compaction actions.
  • Anchor floating rows above the chat input with absolute positioning so automatic status changes do not affect transcript layout.
  • Keep floating rows below the jump-to-bottom chip and make only actual decoration rows pointer-interactive, so empty overlay space does not block transcript selection or clicks.
  • Default newly-created pinned TODO lists to collapsed, while preserving any persisted user expansion.

Validation

  • bun test src/browser/components/ChatPane/LayoutStackLane.test.tsx src/browser/components/PinnedTodoList/PinnedTodoList.test.tsx
  • TEST_INTEGRATION=1 bun x jest tests/ui/compaction/compaction.test.ts --runInBand
  • make static-check

Risks

Medium-low. Automatic status rows now overlay the bottom of the transcript only in the no-banner case. Intentional warning, review, queue, and queued-task rows still take normal layout space and keep automatic rows in the same subtree to avoid overlap and state resets.


Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: 2724476{MUX_COSTS_USD:-unknown}

@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from fcac023 to 2c97c6f Compare May 7, 2026 09:18
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c97c6f25d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/components/ChatPane/ChatPane.tsx Outdated
@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from 2c97c6f to 0ad6952 Compare May 7, 2026 09:24
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from 0ad6952 to f3966f1 Compare May 7, 2026 19:25
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3966f15f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/components/ChatPane/ChatPane.tsx Outdated
@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from f3966f1 to 269186b Compare May 7, 2026 19:33
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 269186b969

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/components/ChatPane/ChatPane.tsx Outdated
@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from 269186b to 1566fb4 Compare May 7, 2026 19:46
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1566fb4702

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/components/ChatPane/ChatPane.tsx Outdated
@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from 1566fb4 to a5a6f7b Compare May 7, 2026 19:53
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5a6f7b06f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/browser/components/ChatPane/ChatPane.tsx Outdated
Reserve collapsed decoration rail space above the workspace chat input so automatic TODO and background bash indicators can appear without resizing the transcript viewport.

Default newly-created pinned TODO indicators to collapsed while preserving persisted user expansion, and cover the stable rail behavior with focused UI tests.

---

_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `1466331{MUX_COSTS_USD:-unknown}`_

<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=5.51 -->
@ibetitsmike ibetitsmike force-pushed the mike/chat-indicators-emr1 branch from a5a6f7b to bf55106 Compare May 7, 2026 20:02
@ibetitsmike
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant