-
Notifications
You must be signed in to change notification settings - Fork 0
Graphify: validate query-reader compatibility before reporting search available #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4100bc8
Graphify: validate query-reader compatibility before reporting search…
jeffhuber 0d19735
Graphify: skip the query-reader check for disconnected connections (#…
jeffhuber 3877a2e
Merge remote-tracking branch 'origin/main' into claude/1029-graphify-…
jeffhuber e6b623a
Graphify: ambiguity-only answers are partial; review the exact provid…
jeffhuber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Performance: connection.status always runs full read_graph even when unverified
In context_graph_connection.py's status() (lines 158-174),
query.search_readiness(...)is called unconditionally before checkingverified = state["state"] == "verified".search_readinessperforms a fullread_graphwhen the generation is usable: opening the tar artifact, extracting and reading up toMAX_GRAPH_BYTES(64 MiB), parsing JSON, and building the wholeCodeGraph. When the connection isdisconnected,searchis forced toSEARCH_UNAVAILABLEregardless (readiness["search"] if verified else query.SEARCH_UNAVAILABLE), so all of that work is thrown away. This is a real, reachable cost on every disconnected connection's status check, not just a corner case. Move thesearch_readinesscall after theverifiedcheck so it only runs when its result can matter, or short-circuit it whennot verified.Skip the expensive read_graph-backed readiness check entirely when the connection is not verified, since its result is discarded anyway.:
Was this helpful? React with 👍 / 👎