Skip to content

chore: Bump structarmed to ^0.17 and enable CodeQuality preset - #1377

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:bump-structarmed-017
Sep 4, 2026
Merged

chore: Bump structarmed to ^0.17 and enable CodeQuality preset#1377
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:bump-structarmed-017

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

Bump structarmed to ^0.17 and enable CodeQuality preset which has 2 rules:

  • MustBeStaticAnonymousFunctionRule: add static to closure/arrow function when possible
  • LargeNumericLiteralMustUseSeparatorRule: use separator _ on large numeric.

On this repo seems no change, but added to sync for future check, synced with CodeIgniter4 repo:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik

Copy link
Copy Markdown
Member Author

Ready to merge 👍 Rector notice is unrelated.

@datamweb datamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@samsonasik

Copy link
Copy Markdown
Member Author

Thank you @datamweb for the review, let's merge 👍

@samsonasik
samsonasik merged commit 53cf9ef into codeigniter4:develop Sep 4, 2026
36 of 37 checks passed
@samsonasik
samsonasik deleted the bump-structarmed-017 branch September 4, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants