fix: Memcached decrement() gives the wrong sign on a missing key - #10512
Open
mdalikadar wants to merge 1 commit into
Open
fix: Memcached decrement() gives the wrong sign on a missing key#10512mdalikadar wants to merge 1 commit into
mdalikadar wants to merge 1 commit into
Conversation
|
Hi there, mdalikadar! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
MemcachedHandler::decrement() passed $offset as Memcached::decrement()'s initial_value, which is used as-is (not decremented from) when a key doesn't exist yet. That made a fresh key end up at +$offset instead of the -$offset every other cache handler (File, Redis, Predis) produces. Memcached counters are unsigned, so they can't hold a negative initial value the way the other handlers effectively can. Use 0 instead (also Memcached::decrement()'s own default), so a fresh key at least stops going the wrong direction. Updates the existing MemcachedHandlerTest::testDecrement() expectation and adds a changelog entry.
mdalikadar
force-pushed
the
fix/memcached-decrement-initial-value
branch
from
August 31, 2026 04:45
d6322dc to
daed2b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10510 (#10510)
Small follow-up to that issue:
MemcachedHandler::decrement()was passing$offsetas the initial value for a key that doesn't exist yet, which madea fresh key end up at
+$offsetinstead of-$offsetlike every othercache handler (File, Redis, Predis) gives you.
I swapped it to use
0instead, since Memcached counters are unsigned andcan't actually go negative — so
0is the closest sane starting point,and it matches what
Memcached::decrement()already defaults to on itsown.
What I changed:
MemcachedHandler::decrement()now passes0instead of$offsetasthe initial value