docs: fix UPLOAD_ERR_XXX typo in UploadedFile docblocks - #10511
Open
mdalikadar wants to merge 1 commit into
Open
docs: fix UPLOAD_ERR_XXX typo in UploadedFile docblocks#10511mdalikadar wants to merge 1 commit into
mdalikadar wants to merge 1 commit into
Conversation
|
Hi there, mdalikadar! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
The $error param/property docblocks in UploadedFile and UploadedFileInterface referred to PHP's error constants as 'UPLOADERRXXX', missing the underscores. The correct constant name is UPLOAD_ERR_XXX, as already used correctly elsewhere in the same files (e.g. the getError() return docblock).
mdalikadar
force-pushed
the
fix/uploadedfile-docblock-typo
branch
from
August 31, 2026 04:45
1fba5e4 to
6f98759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small docblock fix, nothing functional.
The
$errorparam/property docs inUploadedFileandUploadedFileInterfacecall it "UPLOADERRXXX" (no underscores), but thereal PHP constant is
UPLOAD_ERR_XXX. You can tell it's just a typobecause a few lines down in the same files, the
getError()docblockalready spells it correctly.
What I changed:
UploadedFile.phpandUploadedFileInterface.phpNo code behavior changes, just the doc comments.
Let me check on the gh auth login status while you've got this.