Skip to content

Support for global RPGLINT configuration path#435

Draft
francois-rpg wants to merge 23 commits into
codefori:mainfrom
francois-rpg:main
Draft

Support for global RPGLINT configuration path#435
francois-rpg wants to merge 23 commits into
codefori:mainfrom
francois-rpg:main

Conversation

@francois-rpg
Copy link
Copy Markdown

Changes

This PR adds support for specifying a global RPGLINT config path using the new setting rpgle.globalLintConfigPath. If set, linter configs for libraries will be based on this path. This helps enforce company-wide lint standards.

Checklist

  • [Y] have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in the README
  • for feature PRs: PR only includes one feature enhancement.

This is my first pull request to anything on github, ever. Please let me know if and where I went wrong so I contribute cleanly in the future.

@worksofliam worksofliam self-assigned this Jul 30, 2025
@worksofliam worksofliam self-requested a review August 12, 2025 18:43
Copy link
Copy Markdown
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is a great start! I am going to need some files removed from this PR:

  • package-extension.yml - please don't add any new actions to this PR. Perhaps in a separate one if this is something you want to see.
  • Please remove all .vsix files. We don't want to check them into the repo.

Thanks! Then I will go in for a second review 😄

@worksofliam worksofliam removed their assignment Aug 14, 2025
@francois-rpg
Copy link
Copy Markdown
Author

Requested changes completed.
Thank you for the feedback.

Copy link
Copy Markdown
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this has token so long to get to.

  1. Can you please fix the formatting in your new changes? They don't match the indentation of the rest of the file.
  2. Can you fix the conflicts

Thanks!

@SanjulaGanepola
Copy link
Copy Markdown
Member

I think we should standardize with Code for IBM i and make use of the /home/<user>/.vscode directory to store this configuration file much like the settings.json and profiles.json. We can also use the ConfigFile APIs. What do you think?

@francois-rpg
Copy link
Copy Markdown
Author

I think we should standardize with Code for IBM i and make use of the /home/<user>/.vscode directory to store this configuration file much like the settings.json and profiles.json. We can also use the ConfigFile APIs. What do you think?

That is a good idea. I've been thinking about this change, should there also be a switch on/off?
If you're browsing your main repo with old programs you don't necessarily want linting.
Thoughts?

@SanjulaGanepola
Copy link
Copy Markdown
Member

Also I made a typo in my original comment. I meant to type /etc/vscode instead of /home/<user>/.vscode as this is a shared global config directory in Code4i. As long as you use the ConfigFile API, it will automatically use this directory.

should there also be a switch on/off?

Great point actually. I'm wondering what would be the best way to support this though. What where you thinking?

@francois-rpg francois-rpg marked this pull request as draft May 18, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants