Skip to content

Fix backfillReportingChannel to actually resolve channel by name #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
augmentcode wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix backfillReportingChannel to actually resolve channel by name #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/backfillReportingChannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,15 @@ async function main() {

try {
const slack = getSlackClientForEvent(event);
const channelId = await resolveSlackChannelId(slack, event.slackReportingChannelId);
const channelId = await resolveSlackChannelId(
slack,
force ? null : event.slackReportingChannelId,
channelName,
);

if (!channelId) {
skippedNotFound += 1;
console.log(`- ${event.id}: no configured reporting channel ID, skipping`);
console.log(`- ${event.id}: could not find #${channelName} in this workspace, skipping`);
continue;
}

Expand Down
12 changes: 10 additions & 2 deletions src/slack/findSlackChannelByName.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,17 @@ export async function findSlackChannelByName(
));
}

/**
* Returns the channel ID to use for reporting: the already-configured ID if
* one is set, otherwise looks up `channelName` in the workspace by name.
*/
export async function resolveSlackChannelId(
_slack: Pick<WebClient, 'paginate'>,
slack: Pick<WebClient, 'paginate'>,
configuredChannelId: string | null,
channelName: string,
): Promise<string | null> {
return configuredChannelId;
if (configuredChannelId) return configuredChannelId;

const channel = await findSlackChannelByName(slack, channelName);
return channel?.id ?? null;
}
Loading