Skip to content

fix(worker): Resolve N+1 query in ProcessFlakesTask#1431

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-2xd0d5
Open

fix(worker): Resolve N+1 query in ProcessFlakesTask#1431
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-2xd0d5

Conversation

@sentry

@sentry sentry Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query performance issue within the app.tasks.flakes.ProcessFlakesTask.

Problem:
Previously, the process_flakes_for_commit function would iterate through each ReportSession (upload) and, for every upload, call process_single_upload. Inside process_single_upload, get_testruns(upload) was invoked, leading to a separate database query for Testrun objects for each individual upload. This resulted in an N+1 query pattern, where N is the number of uploads.

Additionally, within handle_pass, when a flake reached 30 passes and was considered expired, flake.save() was called individually for each such flake, leading to multiple single-row updates.

Solution:

  1. Batched Testrun Fetch: A new function, get_testruns_for_uploads, was introduced. This function now fetches all relevant Testrun objects for all uploads associated with a commit in a single batched database query. The results are then grouped in memory by upload_id.
  2. Refactored Processing Flow: process_flakes_for_commit now calls get_testruns_for_uploads once before iterating through uploads. process_single_upload was updated to accept the pre-fetched and grouped testruns, eliminating the per-upload database calls.
  3. Bulk Expired Flake Update: The handle_pass function no longer calls flake.save() directly. Instead, expired Flake objects are collected into a list (expired_flakes). After the main processing loop in process_flakes_for_commit completes, these collected expired flakes are updated in a single bulk_update operation.

Impact:
These changes significantly reduce the number of database queries, transforming multiple individual queries into single, efficient batched operations. This improves the performance and reduces the load on the database when processing flakes.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YZ1

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (dab2b40).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1431   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50874    +6     
  Branches     1626     1626           
=======================================
+ Hits        46744    46750    +6     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.54% <12.50%> (-0.03%) ⬇️
workerunit 90.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants