fix(worker): Resolve N+1 query in ProcessFlakesTask#1431
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50874 +6
Branches 1626 1626
=======================================
+ Hits 46744 46750 +6
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue within the
app.tasks.flakes.ProcessFlakesTask.Problem:
Previously, the
process_flakes_for_commitfunction would iterate through eachReportSession(upload) and, for every upload, callprocess_single_upload. Insideprocess_single_upload,get_testruns(upload)was invoked, leading to a separate database query forTestrunobjects for each individual upload. This resulted in an N+1 query pattern, where N is the number of uploads.Additionally, within
handle_pass, when a flake reached 30 passes and was considered expired,flake.save()was called individually for each such flake, leading to multiple single-row updates.Solution:
get_testruns_for_uploads, was introduced. This function now fetches all relevantTestrunobjects for all uploads associated with a commit in a single batched database query. The results are then grouped in memory byupload_id.process_flakes_for_commitnow callsget_testruns_for_uploadsonce before iterating through uploads.process_single_uploadwas updated to accept the pre-fetched and grouped testruns, eliminating the per-upload database calls.handle_passfunction no longer callsflake.save()directly. Instead, expiredFlakeobjects are collected into a list (expired_flakes). After the main processing loop inprocess_flakes_for_commitcompletes, these collected expired flakes are updated in a singlebulk_updateoperation.Impact:
These changes significantly reduce the number of database queries, transforming multiple individual queries into single, efficient batched operations. This improves the performance and reduces the load on the database when processing flakes.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YZ1