Skip to content

fix(worker): Resolve N+1 query in ProcessFlakesTask#1430

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-bIAFSz
Open

fix(worker): Resolve N+1 query in ProcessFlakesTask#1430
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-bIAFSz

Conversation

@sentry

@sentry sentry Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query performance issue within the ProcessFlakesTask by optimizing how Testrun objects are fetched and processed.

Changes Made:

  • Replaced the individual get_testruns(upload) calls within the process_flakes_for_commit loop with a single bulk fetch (get_testruns_for_uploads) for all relevant uploads.
  • Testruns are now grouped by upload_id in memory after the bulk fetch, eliminating repeated database queries inside the loop.
  • Modified handle_pass to collect expired Flake objects into a list, deferring their database updates to a single Flake.objects.bulk_update call at the end of process_flakes_for_commit.
  • Ensured all relevant fields (end_date, count, recent_passes_count) are updated for expired flakes during the bulk update.

These changes significantly reduce the number of database queries executed when processing flakes, improving the performance and efficiency of the ProcessFlakesTask.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YZ0

@codecov-notifications

codecov-notifications Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (e0c0e10).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50875    +7     
  Branches     1626     1626           
=======================================
+ Hits        46744    46751    +7     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.54% <17.64%> (-0.02%) ⬇️
workerunit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants