revert(graphql): Revert server-side changes for ActivateMeasurementsError#1429
Open
sentry[bot] wants to merge 1 commit into
Open
revert(graphql): Revert server-side changes for ActivateMeasurementsError#1429sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50868
Branches 1626 1626
=======================================
Hits 46744 46744
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the server-side changes made to
activate_measurements.graphql,activate_measurements.py, and related files ingraphql_api/types/mutation/mutation.pyandgraphql_api/types/mutation/activate_measurements/__init__.py.During the implementation phase, it was determined that changing the
ActivateMeasurementsErrorunion type to directly use theResolverErrorinterface would lead to runtime issues in GraphQL type resolution, as noInterfaceTyperesolver is registered forResolverError.The root cause analysis concluded that the issue is a client-side GraphQL query error where the client attempts to query the
messagefield directly on a union type (ActivateMeasurementsError) without using inline fragments. The GraphQL schema is correctly defined, and the fix should be applied to the client's query to conform to the GraphQL specification for union types (e.g.,error { __typename ... on ResolverError { message } }).Therefore, these server-side changes are being reverted as they do not address the root cause and would introduce new issues.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EF1