Skip to content

revert(graphql): Revert server-side changes for ActivateMeasurementsError#1429

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/revert/api-ef1-graphql-error-fix
Open

revert(graphql): Revert server-side changes for ActivateMeasurementsError#1429
sentry[bot] wants to merge 1 commit into
mainfrom
seer/revert/api-ef1-graphql-error-fix

Conversation

@sentry

@sentry sentry Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR reverts the server-side changes made to activate_measurements.graphql, activate_measurements.py, and related files in graphql_api/types/mutation/mutation.py and graphql_api/types/mutation/activate_measurements/__init__.py.

During the implementation phase, it was determined that changing the ActivateMeasurementsError union type to directly use the ResolverError interface would lead to runtime issues in GraphQL type resolution, as no InterfaceType resolver is registered for ResolverError.

The root cause analysis concluded that the issue is a client-side GraphQL query error where the client attempts to query the message field directly on a union type (ActivateMeasurementsError) without using inline fragments. The GraphQL schema is correctly defined, and the fix should be applied to the client's query to conform to the GraphQL specification for union types (e.g., error { __typename ... on ResolverError { message } }).

Therefore, these server-side changes are being reverted as they do not address the root cause and would introduce new issues.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes API-EF1

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (0d3d52e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50868           
  Branches     1626     1626           
=======================================
  Hits        46744    46744           
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
apiunit 94.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants