fix(worker): Prevent stale DB connection in apply_async routing#1427
Open
sentry[bot] wants to merge 1 commit into
Open
fix(worker): Prevent stale DB connection in apply_async routing#1427sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.02%
==========================================
Files 1325 1325
Lines 50868 50876 +8
Branches 1626 1626
==========================================
+ Hits 46744 46746 +2
- Misses 3818 3824 +6
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
OperationalError: server closed the connection unexpectedlyoccurring in theapp.tasks.upload.UploadCelery task, specifically during theapply_asyncmethod's task routing logic.Root Cause:
The
apply_asyncoverride inapps/worker/tasks/base.pyqueries the PostgreSQL read replica via_get_user_plan_from_taskto determine task routing. The database connection used for this query was opened at the start of the long-runningUploadtask and was held open without activity. By the timeapply_asyncwas invoked to dispatch follow-up tasks, the read replica had terminated the idle connection server-side, leading to theOperationalErrorwhen the query was attempted.Solution:
To resolve this, the
apply_asyncmethod inapps/worker/tasks/base.pyhas been modified to:get_db_session.remove()at the beginning of the method. This discards any potentially stale SQLAlchemy scoped session (and its underlying connection) that might have been held open during the task's execution._get_user_plan_from_taskand_get_ownerid_from_task).OperationalErrorstill occurs during the initial attempt to query the database for routing, the session is removed again, and the query is retried once. This provides additional robustness against transient connection issues.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YYY