Skip to content

fix(worker): Resolve N+1 queries in ProcessFlakesTask#1426

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-wEF51U
Open

fix(worker): Resolve N+1 queries in ProcessFlakesTask#1426
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-wEF51U

Conversation

@sentry

@sentry sentry Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR addresses two N+1 query patterns identified in the app.tasks.flakes.ProcessFlakesTask within services/test_analytics/ta_process_flakes.py.

Changes Made:

  1. Batched Testrun Fetching:

    • Introduced get_testruns_for_uploads to fetch all Testrun objects for all relevant ReportSession uploads in a single batched query using upload_id__in.
    • The process_flakes_for_commit function now calls this new function once, then distributes the pre-fetched testruns to process_single_upload.
  2. Consolidated Flake Updates:

    • The handle_pass function no longer calls flake.save() individually when a flake expires (reaches 30 passes).
    • Expired flakes are now collected into an expired_flakes list.
    • A single Flake.objects.bulk_update() is performed for all collected expired flakes at the end of process_flakes_for_commit.
  3. Consolidated Testrun Updates:

    • The Testrun.objects.bulk_update() call, previously executed per upload, is now consolidated into a single call at the end of process_flakes_for_commit for all modified testruns.

Reasoning:

These changes eliminate the N+1 query issues, significantly improving performance and reducing database load when processing flakes, especially for commits with a large number of uploads or many expiring flakes.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYX

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (e64ca06).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50868    50881      +13     
  Branches     1626     1626              
==========================================
+ Hits        46744    46755      +11     
- Misses       3818     3820       +2     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.52% <10.00%> (-0.05%) ⬇️
workerunit 90.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants