Skip to content

fix(perf): Batch N+1 queries in ProcessFlakesTask#1424

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/n-plus-1-flakes-task-MJNg6t
Open

fix(perf): Batch N+1 queries in ProcessFlakesTask#1424
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/n-plus-1-flakes-task-MJNg6t

Conversation

@sentry

@sentry sentry Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR addresses two N+1 query issues identified in the app.tasks.flakes.ProcessFlakesTask:

  1. N+1 for Testrun fetching: Previously, process_flakes_for_commit iterated through each upload and called process_single_upload, which in turn called get_testruns(upload). This resulted in a separate database query for Testrun objects for each individual upload.

    • Fix: A new function, get_testruns_for_uploads, was introduced to fetch all relevant Testrun objects for all uploads in a single batched query. process_single_upload now receives a pre-filtered list of testruns, eliminating the N+1 query.
  2. N+1 for expiring Flake saves: When a flake reached 30 recent passes in handle_pass, it would call flake.save() individually to update its end_date.

    • Fix: handle_pass now collects these expiring Flake objects into a list. process_flakes_for_commit then performs a single Flake.objects.bulk_update for all collected expiring flakes, significantly reducing database write operations.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYV

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (a6f89ce).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1424   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50877    +9     
  Branches     1626     1626           
=======================================
+ Hits        46744    46753    +9     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.53% <16.66%> (-0.03%) ⬇️
workerunit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants