Skip to content

fix(worker): eliminate N+1 queries in ProcessFlakesTask#1422

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-eKIi6D
Open

fix(worker): eliminate N+1 queries in ProcessFlakesTask#1422
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-eKIi6D

Conversation

@sentry

@sentry sentry Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query performance issue within the app.tasks.flakes.ProcessFlakesTask by optimizing database interactions when processing test analytics flakes.

Key changes include:

  • Replaced the per-upload fetching of Testrun objects with a single batch query for all relevant uploads, significantly reducing the number of database calls.
  • Batched individual flake.save() operations for expiring flakes into a single Flake.objects.bulk_update call, improving efficiency.
  • Refactored the process_single_upload logic directly into process_flakes_for_commit to streamline the process.
  • Ensured the uploads QuerySet is evaluated only once to prevent redundant database hits.

These changes aim to reduce database load and improve the overall performance of the flake processing task.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYT

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (b17fc18).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1422   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50874    +6     
  Branches     1626     1626           
=======================================
+ Hits        46744    46750    +6     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.53% <11.11%> (-0.03%) ⬇️
workerunit 90.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants