Skip to content

fix(worker): Eliminate N+1 queries in ProcessFlakesTask#1421

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-gPblTB
Open

fix(worker): Eliminate N+1 queries in ProcessFlakesTask#1421
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-process-flakes-n-plus-1-gPblTB

Conversation

@sentry

@sentry sentry Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query issue within the app.tasks.flakes.ProcessFlakesTask.

Problem: The process_flakes_for_commit function iterated through ReportSession uploads and, for each upload, executed a separate database query to fetch associated Testrun objects via get_testruns. This resulted in an N+1 query pattern, where N is the number of uploads for a given commit.

Solution:

  1. A new function, get_testruns_for_uploads, was introduced to fetch all relevant Testrun objects for a list of ReportSession uploads in a single batched query using upload_id__in.
  2. The results are then grouped by upload_id into a dictionary.
  3. process_flakes_for_commit now calls this new batch-fetching function once, and passes the pre-fetched and grouped Testrun objects to process_single_upload.
  4. process_single_upload was updated to accept these pre-fetched testruns, avoiding individual database calls within the loop.

This change significantly reduces the number of database queries from 1 + N to 2 (one for uploads, one for all testruns), improving the performance of the ProcessFlakesTask.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYS

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.88%. Comparing base (701e991) to head (d2c66f3).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...orker/services/test_analytics/ta_process_flakes.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50868    50877       +9     
  Branches     1626     1626              
==========================================
+ Hits        46744    46750       +6     
- Misses       3818     3821       +3     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.53% <8.33%> (-0.03%) ⬇️
workerunit 90.36% <91.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...orker/services/test_analytics/ta_process_flakes.py 91.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants