fix(worker): Eliminate N+1 queries in ProcessFlakesTask#1421
Open
sentry[bot] wants to merge 1 commit into
Open
fix(worker): Eliminate N+1 queries in ProcessFlakesTask#1421sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 1325 1325
Lines 50868 50877 +9
Branches 1626 1626
==========================================
+ Hits 46744 46750 +6
- Misses 3818 3821 +3
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue within the
app.tasks.flakes.ProcessFlakesTask.Problem: The
process_flakes_for_commitfunction iterated throughReportSessionuploads and, for each upload, executed a separate database query to fetch associatedTestrunobjects viaget_testruns. This resulted in an N+1 query pattern, where N is the number of uploads for a given commit.Solution:
get_testruns_for_uploads, was introduced to fetch all relevantTestrunobjects for a list ofReportSessionuploads in a single batched query usingupload_id__in.upload_idinto a dictionary.process_flakes_for_commitnow calls this new batch-fetching function once, and passes the pre-fetched and groupedTestrunobjects toprocess_single_upload.process_single_uploadwas updated to accept these pre-fetched testruns, avoiding individual database calls within the loop.This change significantly reduces the number of database queries from
1 + Nto2(one for uploads, one for all testruns), improving the performance of theProcessFlakesTask.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YYS