fix(perf): Eliminate N+1 query in ProcessFlakesTask#1416
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50873 +5
Branches 1626 1626
=======================================
+ Hits 46744 46749 +5
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue identified in
app.tasks.flakes.ProcessFlakesTask.Problem:
Previously, the
process_flakes_for_commitfunction would iterate over each upload associated with a commit and, for every upload, execute a separate database query to fetch its related testruns. This resulted in an N+1 query pattern, where N is the number of uploads, leading to inefficient database usage.Additionally, the
handle_passfunction would perform individual.save()operations onFlakeobjects when they reached a certain pass count, contributing to more single-row database operations.Solution:
get_testrunsfunction has been replaced withget_testruns_for_uploads. This new function fetches all relevant testruns for all uploads associated with a commit in a single batched query, significantly reducing the number of database calls from N to 1.handle_passfunction no longer performs individual.save()calls. Instead, expiredFlakeobjects are collected into a list and then included in the existingFlake.objects.bulk_createoperation at the end ofprocess_flakes_for_commit. This eliminates individual update queries for expired flakes.These changes drastically reduce the database load and improve the performance of the
ProcessFlakesTaskby converting multiple individual queries into highly optimized bulk operations.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YYQ