Skip to content

fix(perf): Eliminate N+1 queries in ProcessFlakesTask#1414

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-8GvldT
Open

fix(perf): Eliminate N+1 queries in ProcessFlakesTask#1414
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/worker-n-plus-1-flakes-8GvldT

Conversation

@sentry

@sentry sentry Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query issue identified in the app.tasks.flakes.ProcessFlakesTask.

Problem:
Previously, the process_flakes_for_commit function would iterate over each upload associated with a commit. For every upload, it would perform separate database SELECT queries to fetch Testrun objects and then separate UPDATE queries via bulk_update on the ta_timeseries_testrun table. This led to an N+1 query pattern, where N is the number of uploads for a given commit, causing significant performance overhead.

Solution:
This change refactors the process_flakes_for_commit and process_single_upload functions to batch database operations:

  1. get_testruns was modified to accept a list of ReportSession objects and now fetches all relevant Testrun objects for all uploads in a single SELECT query using upload_id__in.
  2. The fetched Testrun objects are then grouped by upload_id in memory.
  3. process_single_upload was updated to receive a pre-filtered list of Testrun objects, removing its internal database calls.
  4. All modified Testrun objects from all uploads are collected, and a single Testrun.objects.bulk_update is performed after processing all uploads, eliminating the N individual UPDATE queries.

This significantly reduces the number of database round trips, improving the performance of the ProcessFlakesTask.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYN

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (fa0e4d4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50871    +3     
  Branches     1626     1626           
=======================================
+ Hits        46744    46747    +3     
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.54% <10.00%> (-0.02%) ⬇️
workerunit 90.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants