Skip to content

perf: Bulk-fetch testruns and update flakes in ProcessFlakesTask#1413

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/perf/process-flakes-n-plus-1-PpPgsG
Open

perf: Bulk-fetch testruns and update flakes in ProcessFlakesTask#1413
sentry[bot] wants to merge 1 commit into
mainfrom
seer/perf/process-flakes-n-plus-1-PpPgsG

Conversation

@sentry

@sentry sentry Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This PR addresses an N+1 query performance issue identified in the app.tasks.flakes.ProcessFlakesTask, specifically within the services.test_analytics.ta_process_flakes.py module.

Problem:
Previously, process_flakes_for_commit would iterate over each upload and call process_single_upload, which in turn would execute a separate database query via get_testruns(upload) to fetch testruns for that specific upload. This resulted in an N+1 query pattern (1 query for uploads + N queries for testruns).
Additionally, handle_pass would perform individual flake.save() calls for each expiring flake, leading to further per-row database operations.

Solution:

  1. Bulk-fetch Testruns: A new function get_testruns_for_uploads was introduced to fetch all relevant testruns for all uploads in a single database query using upload_id__in=[...]. These testruns are then grouped by upload_id in memory.
  2. Optimized process_single_upload: The process_single_upload function was updated to accept the pre-fetched list of testruns, eliminating the need for individual database queries within the loop.
  3. Bulk-update Expired Flakes: The handle_pass function no longer calls flake.save() directly. Instead, expired flakes are collected into a list (expired_flakes) and then bulk-updated in a single operation after the main processing loop in process_flakes_for_commit.

These changes significantly reduce the number of database queries executed during the ProcessFlakesTask, improving its performance.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYM

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (fa829dd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files        1325     1325              
  Lines       50868    50879      +11     
  Branches     1626     1626              
==========================================
+ Hits        46744    46753       +9     
- Misses       3818     3820       +2     
  Partials      306      306              
Flag Coverage Δ
workerintegration 58.53% <11.11%> (-0.04%) ⬇️
workerunit 90.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants