perf: Bulk-fetch testruns and update flakes in ProcessFlakesTask#1413
Open
sentry[bot] wants to merge 1 commit into
Open
perf: Bulk-fetch testruns and update flakes in ProcessFlakesTask#1413sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 1325 1325
Lines 50868 50879 +11
Branches 1626 1626
==========================================
+ Hits 46744 46753 +9
- Misses 3818 3820 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue identified in the
app.tasks.flakes.ProcessFlakesTask, specifically within theservices.test_analytics.ta_process_flakes.pymodule.Problem:
Previously,
process_flakes_for_commitwould iterate over eachuploadand callprocess_single_upload, which in turn would execute a separate database query viaget_testruns(upload)to fetch testruns for that specific upload. This resulted in an N+1 query pattern (1 query for uploads + N queries for testruns).Additionally,
handle_passwould perform individualflake.save()calls for each expiring flake, leading to further per-row database operations.Solution:
get_testruns_for_uploadswas introduced to fetch all relevant testruns for all uploads in a single database query usingupload_id__in=[...]. These testruns are then grouped byupload_idin memory.process_single_upload: Theprocess_single_uploadfunction was updated to accept the pre-fetched list of testruns, eliminating the need for individual database queries within the loop.handle_passfunction no longer callsflake.save()directly. Instead, expired flakes are collected into a list (expired_flakes) and then bulk-updated in a single operation after the main processing loop inprocess_flakes_for_commit.These changes significantly reduce the number of database queries executed during the
ProcessFlakesTask, improving its performance.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YYM