Skip to content

fix(jacoco): Handle missing 'missed' and 'covered' attributes in complexity counter#1412

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/jacoco-missed-keyerror
Open

fix(jacoco): Handle missing 'missed' and 'covered' attributes in complexity counter#1412
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/jacoco-missed-keyerror

Conversation

@sentry

@sentry sentry Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This PR addresses a KeyError: 'missed' occurring in the JaCoCo report parser (apps/worker/services/report/languages/jacoco.py).

The root cause was identified as direct dictionary access (counter.attrib["missed"] and counter.attrib["covered"]) on <counter type="COMPLEXITY"> elements within JaCoCo XML reports. In some valid JaCoCo outputs (e.g., for abstract methods), these attributes might be absent, leading to a KeyError.

The fix replaces these direct accesses with .get("attribute_name", "0"), providing a default value of 0 when the attributes are missing. This ensures robust parsing of JaCoCo reports without crashing, aligning with the existing defensive parsing patterns in the file.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YYK

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (701e991) to head (daba8a5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1325     1325           
  Lines       50868    50868           
  Branches     1626     1626           
=======================================
  Hits        46744    46744           
  Misses       3818     3818           
  Partials      306      306           
Flag Coverage Δ
workerintegration 58.56% <0.00%> (ø)
workerunit 90.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

codecov-notifications Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants