fix(worker): Optimize N+1 query in ProcessFlakesTask#1410
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.01%
==========================================
Files 1325 1325
Lines 50868 50878 +10
Branches 1626 1626
==========================================
+ Hits 46744 46751 +7
- Misses 3818 3821 +3
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue identified in
app.tasks.flakes.ProcessFlakesTask, specifically within theservices.test_analytics.ta_process_flakes.pymodule.Problem:
Previously, the
process_flakes_for_commitfunction would iterate over eachReportSession(upload) and, for every upload, execute a separate database query to fetch its associatedTestrunobjects viaget_testruns(upload). This led to an N+1 query pattern, where 1 query fetched the uploads, and then N additional queries were made for the testruns, significantly impacting performance for commits with many uploads.Solution:
To resolve this, the
Testrunobjects for all relevant uploads are now fetched in a single batch query usingupload_id__inbefore the iteration begins. A new helper function,get_testruns_for_uploads, handles this batch fetching and groups the results byupload_idin Python. Theprocess_single_uploadfunction was updated to accept these pre-fetched and grouped testruns, eliminating the need for individual database calls within the loop.Impact:
This change reduces the number of database queries from an N+1 pattern (1 for uploads + N for testruns) to a constant 2 queries (1 for uploads + 1 for all testruns), regardless of the number of uploads, thereby improving the efficiency and performance of the
ProcessFlakesTask.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YYH