fix(flakes): Resolve N+1 query in ProcessFlakesTask#1409
Open
sentry[bot] wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50875 +7
Branches 1626 1626
=======================================
+ Hits 46744 46751 +7
Misses 3818 3818
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in
app.tasks.flakes.ProcessFlakesTask, specifically within theprocess_flakes_for_commitfunction inapps/worker/services/test_analytics/ta_process_flakes.py.Problem:
Previously, when processing flakes for a commit, the
process_flakes_for_commitfunction would iterate over eachReportSession(upload). For each upload, it would callprocess_single_upload, which in turn performed a separateSELECTquery to fetch testruns and abulk_updateoperation onTestrunobjects. This led to an O(2N) query pattern, where N is the number of uploads for a given commit.Solution:
get_testruns_for_uploadsto fetch all relevantTestrunobjects for all uploads associated with a commit in a singleSELECTquery. The results are grouped byupload_idfor efficient lookup.process_single_upload: Modifiedprocess_single_uploadto accept the pre-fetched list ofTestrunobjects directly, eliminating its internal database query.Testrunobjects across all uploads are now collected into a single list. A singleTestrun.objects.bulk_updatecall is performed after the loop, updating all outcomes in one go.Impact:
This change reduces the database query count from O(2N) to O(2) per commit, significantly improving performance and reducing database load when processing test analytics flakes.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-YYG