feat: link OwnerAdmin owner-id array fields to admin pages#1407
Open
thomasrockhu-codecov wants to merge 1 commit into
Open
feat: link OwnerAdmin owner-id array fields to admin pages#1407thomasrockhu-codecov wants to merge 1 commit into
thomasrockhu-codecov wants to merge 1 commit into
Conversation
Render the admins, organizations, and permission array fields as read-only lists of links to the related admin change pages. Owner-id arrays (admins, organizations) link to each Owner and are labelled "<ownerid> — <username> (<email>)"; the permission array (repoids) links to each Repository, labelled "<repoid> — <owner>/<repo> (private|public)". Missing ids render as "<id> — (not found)". This lets staff see who each id refers to and jump straight to the related record instead of eyeballing raw integer arrays.
2 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 1325 1325
Lines 50868 50902 +34
Branches 1626 1626
=======================================
+ Hits 46744 46777 +33
- Misses 3818 3819 +1
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the raw owner-id / repo-id array fields on the Django
OwnerAdminchange page human-readable.adminsandorganizations(owner-id arrays) render as read-only lists of links to eachOwner's change page, labelled<ownerid> — <username> (<email>).permission(repo-id array) renders as links to eachRepository's change page, labelled<repoid> — <owner>/<repo> (private|public).<id> — (not found).This lets staff see who/what each id refers to and jump straight to the related record instead of eyeballing raw integer arrays. The array fields are surfaced through read-only
*_displaymethods (the raw fields stay excluded from the editable form).Test plan
pytest codecov_auth/tests/test_admin.py::OwnerAdminTest(addedtest_admins_display_*,test_organizations_display_*,test_permission_display_*,test_admins_and_organizations_are_read_only).Notes
Split out from the combined change; the changelist count-query performance fix is in a separate PR (#1406).
Made with Cursor