fix: Prevent TypeError from caching API error responses - #170
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 149 bytes (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: codecov-browser-extension-array-pushAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: .map is not a functionoccurring ingetComponents(and potentiallygetFlags) when the Codecov browser extension attempts to process cached API responses.Root Cause:
Previously,
src/service.tsunconditionally cached API responses, including error objects (e.g., JSON bodies from 404, 403, or 429 HTTP statuses). When these cached error objects were retrieved, they were returned withok: true, leadingsrc/content/github/common/fetchers.tsto incorrectly assume theresponse.datawas an array and attempt to call.map()on it, resulting in theTypeError.Solution:
src/service.ts, the calls tosetCachedwithinlistFlagsandlistComponentsare now guarded byresponse.ok. This ensures that only successful API responses are stored in the cache, preventing error objects from being treated as valid data.Array.isArray()checks: Insrc/content/github/common/fetchers.ts,Array.isArray()checks have been added before calling.map()in bothgetComponentsandgetFlags. This provides an additional layer of protection, ensuring that.map()is only ever called on actual arrays, even if a non-array value were to somehow reach these functions.This fix aligns with the proposed solution in PR #164.
Fixes BROWSER-EXTENSION-DW
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.