fix: Avoid error when Raw button is absent on GitHub file pages - #169
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 248 bytes (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: codecov-browser-extension-array-pushAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the "Error: Raw button not found" issue (BROWSER-EXTENSION-SJ) that occurred when the browser extension was active on GitHub file pages that do not display a 'Raw' button (e.g., binary files, images, LFS-tracked files).
Root Cause: The extension's logic assumed the presence of a
[data-testid="raw-button"]element on all/blob/URLs. However, GitHub only renders this button for plain-text files. When navigating to other file types, thedocument.querySelectorcall would returnnull, leading to an unhandled error.Changes Made:
src/content/github/file/main.tsx: Added an explicit check for the[data-testid="raw-button"]element within themain()function. If the button is not found, the extension now logs a message and returns early, preventingcreateCoverageButton()from being called and thus avoiding the error.src/content/github/file/utils/dropdown.tsx: Modified thecreateDropdown()function to returnnullinstead of throwing an error if the[data-testid="raw-button"]is not found. This makes the function more robust and allows callers to handle its absence gracefully.src/content/github/file/main.tsx: Updated the call sites forcreateDropdown()to check for anullreturn value. IfcreateDropdown()returnsnull, the subsequent logic for creating and attaching the dropdown (flags and components) is skipped, ensuring no further errors occur.Fixes BROWSER-EXTENSION-SJ
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.