fix: Prevent TypeError from orphaned content script - #168
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 176 bytes (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: codecov-browser-extension-array-pushAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'local')that occurs in the GitHub file content script (src/content/github/file/main.tsx).Root Cause:
In Chrome Manifest V3, when the browser extension is reloaded or updated while a content script is already running on a tab, the extension context for that content script becomes invalidated. This causes
browser.storage(which is a polyfill forchrome.storage) to becomeundefined. Subsequent attempts to accessbrowser.storage.localthen throw aTypeError.Solution:
To prevent this, a new helper function
isExtensionContextValid()has been introduced. This function checksbrowser.runtime?.id, which will beundefinedif the extension context has been invalidated. Themain()function insrc/content/github/file/main.tsxnow calls this validity check at its entry point. If the context is invalid,main()will return early, preventing any access tobrowser.storage.localand gracefully handling the orphaned content script scenario. This protects both initial page loads and subsequentsoft-nav:endevents from triggering the error.Fixes BROWSER-EXTENSION-SH
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.