Skip to content

fix: Ensure component and flag data is always an array before mapping #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

fix: Ensure component and flag data is always an array before mapping #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/content/github/common/fetchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export async function getFlags(metadata: FileMetadata): Promise<string[]> {
referrer: window.location.href,
});

const flags = response.ok ? response.data.results : [];
const flags = Array.isArray(response.data?.results) ? response.data.results : [];

return flags.map((f: any) => f.flag_name);
}
Expand All @@ -35,7 +35,7 @@ export async function getComponents(metadata: FileMetadata): Promise<string[]> {
referrer: window.location.href,
});

const components = response.ok ? response.data : [];
const components = Array.isArray(response.data) ? response.data : [];

return components.map((c: any) => c.component_id);
}
Expand Down
8 changes: 6 additions & 2 deletions src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ export class Codecov {
});
const data = await response.json();

await this.setCached("flags", owner, repo, data);
if (response.ok) {
await this.setCached("flags", owner, repo, data);
}

return {
ok: response.ok,
Expand Down Expand Up @@ -246,7 +248,9 @@ export class Codecov {
});
const data = await response.json();

await this.setCached("components", owner, repo, data);
if (response.ok) {
await this.setCached("components", owner, repo, data);
}

return {
ok: response.ok,
Expand Down
Loading