implemented path normalization - #5451
Merged
Merged
Conversation
added 2 commits
February 13, 2026 03:01
DenysKuchma
approved these changes
Feb 16, 2026
added 5 commits
February 17, 2026 14:08
30 tasks
DavertMik
pushed a commit
that referenced
this pull request
Sep 8, 2026
#5451 wired resolveUrl() into waitInUrl alongside waitUrlEquals. For waitUrlEquals that is correct — a strict comparison needs the relative path resolved against the configured base url. For waitInUrl it silently turned a documented substring match into an origin-anchored one: const expectedUrl = resolveUrl(urlPart, this.options.url) // '/users' -> 'https://app.example.com/users' return currUrl.indexOf(expectedUrl) > -1 // scheme+host+port must now match exactly So I.waitInUrl('/users') breaks after a redirect to a different host, port or scheme, and a partial match such as I.waitInUrl('user=test') resolves to <base>/user=test and never matches /info?user=test. Compare against the raw urlPart again in Playwright, Puppeteer and WebDriver. waitUrlEquals is left untouched. The existing test asserted only inside catch, so it passed vacuously whenever the wait unexpectedly succeeded — which is how this shipped. It now fails on a missing timeout, plus a new case pinning the regression. docs/migration-4.md listed waitInUrl among the methods that resolve relative urls while its own example said the opposite; corrected. Co-authored-by: Claude <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)