Skip to content

Fix edit drawer open action #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebude merged 2 commits into from
Jun 22, 2026
+0 −8
Merged

Fix edit drawer open action #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16257c
Fix edit drawer open action
codebude Jun 22, 2026
a2d2ccf
Merge pull request #55 from codebude/bugfix/details-drawer-opening
codebude Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions frontend/src/lib/components/BookDetailDialog.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,13 +312,11 @@
});

// ── Android back button: close drawer instead of navigating away ──────────
let _pushed = false;
let _popClosed = false;

$effect(() => {
if (open) {
history.pushState(null, '');
_pushed = true;
_popClosed = false;

const onPop = () => {
Expand All @@ -328,8 +326,6 @@
window.addEventListener('popstate', onPop);
return () => {
window.removeEventListener('popstate', onPop);
if (_pushed && !_popClosed) history.back();
_pushed = false;
_popClosed = false;
};
}
Expand Down
4 changes: 0 additions & 4 deletions frontend/src/lib/components/BookDrawer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,11 @@
let cover_url = $state<string | null>(null);

// ── Android back button: close drawer instead of navigating away ──────────
let _pushed = false;
let _popClosed = false;

$effect(() => {
if (open) {
history.pushState(null, '');
_pushed = true;
_popClosed = false;

const onPop = () => {
Expand All @@ -77,8 +75,6 @@
window.addEventListener('popstate', onPop);
return () => {
window.removeEventListener('popstate', onPop);
if (_pushed && !_popClosed) history.back();
_pushed = false;
_popClosed = false;
};
}
Expand Down
Loading