Repository navigation
fix: publish REST module definitions - #84
Merged
Merged
Conversation
raphael-goetz
changed the title
rest-action never sent Module.definitions to Aquila, so unlike the old draco REST adapter, there was no way to discover its externally reachable endpoint. hercules-sdk 1.5.0 has no hook for this at all (Action::build_module hardcoded an empty definitions list), so this pins hercules-sdk to a commit on code0-tech/hercules that adds Action::definition for exactly that, until the fix is released. HttpServerConfig mirrors draco's EXTERNAL_HTTP_SERVER_HOST/PORT and HTTPS_CONFIGURED env var conventions so existing deployments don't need new configuration to pick this up. Refs #80
Replaces the interim git-rev pin from the previous commit now that code0-tech/hercules#53 (Action::definition) is released. 1.7.2 also carries main's RuntimeFunctionHandler::run signature change (returns RuntimeFunctionReturn instead of a bare PlainValue), so Respond is updated to match; no behavior change for it otherwise. Refs #80
raphael-goetz
force-pushed
the
fix/#80-rest-module-definitions
branch
from
November 1, 2026 09:41
ce96948 to
e97744d
Compare
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/centaurus/-/pipelines/3014231745 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/17642711765/artifacts/out/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80