fix(scripts): decouple release detector from fork remotes#278
Open
realsigridjin wants to merge 1 commit into
Open
fix(scripts): decouple release detector from fork remotes#278realsigridjin wants to merge 1 commit into
realsigridjin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstreamremote asbadlogic/pi-monoVerification
node --test scripts/check-upstream-release.test.mjsnpm run test:scripts(48/48 passed)npm run checknpm run buildNotes
id: customfix is already merged in fix: omit invalid "custom" item ids when replaying custom tool calls to the Responses API #271 and is intentionally not duplicated here.npm teston Node 25 reached two unrelated baseline failures: npm 11 config warnings captured by an install test and a 1 ms timestamp precision assertion. The affected script suite is fully green.Summary by cubic
Decoupled the upstream release detector from contributor remotes to always read releases and main from the real
badlogic/pi-monorepository. Prevents false positives when a fork has anupstreamremote pointing elsewhere.git ls-remoteandgit fetchcalls (no reliance on a localupstreamremote).refs/heads/mainintorefs/remotes/pi-mono/mainand resolve SHAs from that ref for consistency.upstreamremote, verify SHAs via the real upstream URL, and restore original remotes after.GITHUB_OUTPUTto avoid output file writes.Written for commit 222bc69. Summary will update on new commits.