feat: generic openAsSheet support with auto-adapting dismiss style#750
Merged
Conversation
github-actions
Bot
added
type: feature
bmc08gt
force-pushed
the
feat/open-as-sheet
branch
from
5bc2fce to
503df1d
Compare
- Add openAsSheet(route) to open any AppRoute as a modal bottom sheet with animated dismiss-replace when a sheet is already open - Add FlowDismissStyle composition local so FlowHost auto-swaps back arrow for close (X) when at a sheet root first step - Rename navigateTo(list) to navigateAll for clarity; remove single-route navigateTo overload - Widen Main.Sheet.initialRoute from Sheets to AppRoute - Remove duplicate Sheets.TokenDiscovery route and TokenDiscoverySheet() - Remove dead Menu.Deposit route - Fix SaveableStateProvider duplicate-key crash in pendingSheetDismiss by removing sheetGeneration from key() block and using it as LaunchedEffect key instead - Guard onDismissRequest during pendingSheetDismiss to prevent double onBack()
bmc08gt
force-pushed
the
feat/open-as-sheet
branch
from
503df1d to
fa43e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.