fix(navigation): prevent duplicate Sheet key crash in single-route navigation#741
Merged
Merged
Conversation
github-actions
Bot
added
type: fix
…vigateTo The single-route navigateTo(route) extension called navigate() directly without checking whether a sheet was already open. This allowed a second Sheet(TokenDiscovery) to land on the backstack during a dismiss animation, crashing SaveableStateProvider with 'Key was used multiple times'. - Single-route navigateTo now defers via pendingSheetDismiss when a sheet is already present, matching the multi-route overload behavior - Add Sheet dedup guard to the ClearAll navigate branch - Add async duplicate Sheet sanitization in AppNavHost as a safety net - Add 4 test cases covering the single-route dismiss-then-replace flow
bmc08gt
force-pushed
the
fix/sheet-duplicate-key-crash
branch
from
0a70257 to
fb6925e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-route navigateTo(route) extension called navigate() directly without checking whether a sheet was already open. This allowed a second Sheet(TokenDiscovery) to land on the backstack during a dismiss animation, crashing SaveableStateProvider with 'Key was used multiple times'.