Fix chapters shortcut in fullscreen - #4284
Open
jvsilva12600009 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4283
What
Fix the Chapters (Sidebar) On/Off shortcut so it can handle the chapters control while YouTube is in fullscreen.
The change also makes the shortcut safer when the chapters UI is not available, avoiding errors caused by accessing missing DOM elements.
Why
The chapters shortcut worked in the normal YouTube layout, but did not work correctly in fullscreen because the fullscreen player uses a different chapters control.
The existing implementation also assumed that the normal chapters panel was always present.
How
Testing
npx jest tests/unit/shortcut-chapters-fullscreen.test.jsnpm testnpm run lint