Fix/sidebar comments playlist - #4276
Open
FaiziNerd wants to merge 2 commits into
Open
Conversation
…ity#4254) Learn AI disclosure labels on watch/Shorts, remember video IDs, and hide those items site-wide like other feed filters. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#secondaryand under-player content reachableRoot cause
Comments-sidebar CSS locked
#columnsto viewport height withoverflow: hidden, while#primaryusedflex-shrink: 0andresizePlayer()could set an oversized inline width. Playlist/live chat live in#secondary, so that column (and related videos under the player) were clipped off-screen.Changes
#primaryto shrink (flex: 1 1 auto) and keep#secondaryfrom being squeezed awayresizePlayer()so primary width always leaves room for the secondary column (≥300px)#columns { height: auto }actually appliesTest plan
Fixes Issue #4237