fix: increase Key Scene button tooltip z-index to prevent overlap with video description (#4138) - #4256
Open
waterWang wants to merge 2 commits into
Open
Conversation
…ode-charity#4216) The universal *[data-value][data-value="true"] selector in satus.css applied negative margins to ALL elements with data-value="true", including toggle switches (.satus-switch). When a toggle was turned on, the negative margins compressed the switch vertically, making the entire menu entry row appear narrower. Fix: add .satus-switch[data-value] rule to reset margins to 0, overriding the universal selector's negative margins.
…iption text (code-charity#4138) The Key Scene button's tooltip (z-index: 1002) was appearing below the player controls and overlapping with the video description text. This fix: 1. Increases z-index from 1002 to 999999 to ensure the tooltip always renders above YouTube's description text 2. Adds white-space: nowrap to prevent the tooltip text from wrapping, ensuring clean single-line display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4138 — The Key Scene button's tooltip text was overlapping with the video description text below the player controls.
Changes
File:
js&css/extension/www.youtube.com/styles.css1002 → 999999— ensures the tooltip renders above YouTube's description text, which had a higher stacking contextwhite-space: nowrap— prevents the tooltip text from wrapping, ensuring a clean single-line displayBefore
Hovering over the Key Scene button showed the tooltip text overlapping with the video description text below the player controls.
After
The tooltip appears cleanly on top of the description text without overlapping.
Testing
.improvedtube-player-button:hover::afteronly